Skip to content

CloudQuery-GCP C2C doc #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 16, 2024
Merged

CloudQuery-GCP C2C doc #4069

merged 23 commits into from
May 16, 2024

Conversation

kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented May 10, 2024 •
edited
Loading

Purpose of this pull request

This pull request adds CloudQuery GCP C2C doc and CID.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/CONN-3157

@kimsauce kimsauce self-assigned this May 10, 2024
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label May 10, 2024
@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label May 10, 2024
@kimsauce kimsauce changed the title CloudQuery GCP C2C CloudQuery GCP DRAFT May 10, 2024
@kimsauce kimsauce marked this pull request as draft May 10, 2024 15:19
@kimsauce kimsauce assigned JV0812 and unassigned kimsauce May 12, 2024
@kimsauce
Copy link
Collaborator Author

Hi @JV0812 , can I hand this off to you? Left some notes in the Jira ticket and your Google Doc.

@JV0812
Copy link
Collaborator

JV0812 commented May 15, 2024

Sure @kimsauce, I will take up this PR. Thanks for working on this.

@JV0812 JV0812 marked this pull request as ready for review May 15, 2024 06:22
jpipkin1
jpipkin1 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JV0812, I approved the PR contingent on your addressing my suggestions.

JV0812 and others added 9 commits May 16, 2024 09:27
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
6b991a3 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
942db4e 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
f4eb348 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
b2f23a9 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
3b9e583 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
deed937 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
cf3d92b 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
68ab433 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812 @jpipkin1
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
88f28df 
…amework/cloudquery-gcp-source.md

Co-authored-by: John Pipkin (Sumo Logic) <jpipkin@sumologic.com>
@JV0812
Copy link
Collaborator

JV0812 commented May 16, 2024

@jpipkin1 Thanks for your review, I have incorporated your comments.

@kimsauce kimsauce changed the title CloudQuery GCP DRAFT CloudQuery-GCP C2C doc May 16, 2024
@JV0812 JV0812 removed the do-not-merge Pull requests that should not be merged label May 16, 2024
JV0812 and others added 2 commits May 16, 2024 14:25
@JV0812 @kimsauce
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
8d2849d 
…amework/cloudquery-gcp-source.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@JV0812 @kimsauce
Update docs/send-data/hosted-collectors/cloud-to-cloud-integration-fr…
e9d3055 
…amework/cloudquery-gcp-source.md

Co-authored-by: Kim (Sumo Logic) <56411016+kimsauce@users.noreply.github.com>
@JV0812 JV0812 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 8499a03 May 16, 2024
3 checks passed
@JV0812 JV0812 deleted the CONN-3157-cloud-query-gcp-inventory-doc-generation branch May 16, 2024 09:36
@jpipkin1
Copy link
Collaborator

@kimsauce , we’re removing the CloudQuery GCP Source beta article with PR #4209 at the request of @arpit Jaiswal (see Slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

Assignees

@JV0812 JV0812

Labels
cla-signed Contributor approved, listed in .clabot file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kimsauce @JV0812 @jpipkin1